Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Native tokens Tab to address pages #1119

Merged
merged 21 commits into from
Feb 18, 2024
Merged

feat: Add Native tokens Tab to address pages #1119

merged 21 commits into from
Feb 18, 2024

Conversation

brancoder
Copy link
Collaborator

Description of change

resolves #1078

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Base automatically changed from feat/add-outputs-tab to dev February 14, 2024 15:11
@brancoder brancoder linked an issue Feb 14, 2024 that may be closed by this pull request
[Task]: Add native tokens tab to all address pages #1078
Closed
@begonaalvarezd begonaalvarezd changed the title Fix: Add Native tokens Tab to address pages feat: Add Native tokens Tab to address pages Feb 14, 2024
@brancoder brancoder marked this pull request as ready for review February 15, 2024 09:07
@brancoder brancoder requested a review from msarcev February 16, 2024 14:53
@msarcev
Copy link
Collaborator

msarcev commented Feb 16, 2024

Seams like we lost the behaviour of "pre-selecting" the first tab somehow
image

@brancoder brancoder merged commit 61ff442 into dev Feb 18, 2024
4 of 6 checks passed
@brancoder brancoder deleted the feat/add-native-tokens-tab branch February 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msarcev msarcev msarcev approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add native tokens tab to all address pages
2 participants
@brancoder @msarcev